Skip to content

Conversation

@nvinjam-amazon
Copy link
Contributor

Description

  • Updated the version check logic between OSD and its plugins to only major version check during the start of the server.

Issues Resolved

 FATAL  Error: Failed to initialize plugins:
        Plugin "alertingDashboards" is only compatible with OpenSearch Dashboards version "3.3.0", but used OpenSearch Dashboards version is "3.4.0". (incompatible-version, /local/home/nvinjam/Github/OpenSearch-Dashboards/plugins/alerting-dashboards-plugin/opensearch_dashboards.json)

Screenshot

Testing the changes

(25-10-28 17:23:29) <0> [~/Github/OpenSearch-Dashboards]  
dev-dsk-nvinjam-2b-86031268 % yarn start
yarn run v1.22.19
$ scripts/use_node scripts/opensearch_dashboards --dev
  log   [17:23:40.073] [info][plugins-service] Plugin "applicationConfig" is disabled.
  log   [17:23:40.078] [info][plugins-service] Plugin "banner" is disabled.
  log   [17:23:40.078] [info][plugins-service] Plugin "chat" is disabled.
  log   [17:23:40.079] [info][plugins-service] Plugin "contextProvider" is disabled.
  log   [17:23:40.079] [info][plugins-service] Plugin "cspHandler" is disabled.
  log   [17:23:40.080] [info][plugins-service] Plugin "dataImporter" is disabled.
  log   [17:23:40.080] [info][plugins-service] Plugin "dataSource" is disabled.
  log   [17:23:40.080] [info][plugins-service] Plugin "datasetManagement" is disabled.
  log   [17:23:40.081] [info][plugins-service] Plugin "explore" is disabled.
  log   [17:23:40.081] [info][plugins-service] Plugin "visTypeXy" is disabled.
  log   [17:23:40.082] [info][plugins-service] Plugin "workspace" is disabled.
  log   [17:23:40.121] [info][dynamic-config-service] registering middleware to inject context to AsyncLocalStorage
[agentkeepalive:deprecated] options.freeSocketKeepAliveTimeout is deprecated, please use options.freeSocketTimeout instead
  log   [17:23:40.184] [info][plugins-service] Plugin initialization disabled.
  log   [17:23:40.193] [info][dynamic-config-service] initiating start()
  log   [17:23:40.194] [info][dynamic-config-service] finished start()
  log   [17:23:40.206] [warning][savedobjects-service] Skipping Saved Object migrations on startup. Note: Individual documents will still be migrated when read or written.
  log   [17:23:40.210] [warning][cross-compatibility-service] Starting cross compatibility service
np bld    log   [17:23:40.854] [info][@osd/optimizer] initialized, 0 bundles cached
np bld    log   [17:23:41.594] [info][@osd/optimizer] starting worker [10 bundles]
np bld    log   [17:23:41.613] [info][@osd/optimizer] starting worker [10 bundles]
np bld    log   [17:23:41.749] [info][@osd/optimizer] starting worker [10 bundles]
np bld    log   [17:23:41.751] [info][@osd/optimizer] starting worker [10 bundles]
np bld    log   [17:23:41.752] [info][@osd/optimizer] starting worker [10 bundles]
np bld    log   [17:23:41.877] [info][@osd/optimizer] starting worker [10 bundles]
 watching for changes  (2484 files)
  log   [17:23:42.037] [info][server] basepath proxy server running at http://localhost:5601/nho
server    log   [17:24:14.452] [info][plugins-service] Plugin "applicationConfig" is disabled.
server    log   [17:24:14.512] [info][plugins-service] Plugin "banner" is disabled.
server    log   [17:24:14.518] [info][plugins-service] Plugin "chat" is disabled.
server    log   [17:24:14.520] [info][plugins-service] Plugin "contextProvider" is disabled.
server    log   [17:24:14.522] [info][plugins-service] Plugin "cspHandler" is disabled.
server    log   [17:24:14.547] [info][plugins-service] Plugin "dataImporter" is disabled.
server    log   [17:24:14.554] [info][plugins-service] Plugin "dataSource" is disabled.
server    log   [17:24:14.564] [info][plugins-service] Plugin "datasetManagement" is disabled.
server    log   [17:24:14.570] [info][plugins-service] Plugin "explore" is disabled.
server    log   [17:24:14.572] [info][plugins-service] Plugin "visTypeXy" is disabled.
server    log   [17:24:14.578] [info][plugins-service] Plugin "workspace" is disabled.
server    log   [17:24:15.361] [info][dynamic-config-service] registering middleware to inject context to AsyncLocalStorage
[agentkeepalive:deprecated] options.freeSocketKeepAliveTimeout is deprecated, please use options.freeSocketTimeout instead
server    log   [17:24:16.339] [info][plugins-system] Setting up [41] plugins: [usageCollection,opensearchDashboardsUsageCollection,opensearchDashboardsLegacy,mapsLegacy,opensearchUiShared,share,legacyExport,embeddable,expressions,data,savedObjects,queryEnhancements,home,dashboard,visualizations,visTypeVega,visTypeTimeline,visTypeTable,visTypeMarkdown,visBuilder,visAugmenter,tileMap,regionMap,inputControlVis,visualize,apmOss,management,indexPatternManagement,dataSourceManagement,alertingDashboards,console,advancedSettings,dataExplorer,charts,visTypeVislib,visTypeTimeseries,visTypeTagcloud,visTypeMetric,discover,savedObjectsManagement,bfetch]
[agentkeepalive:deprecated] options.freeSocketKeepAliveTimeout is deprecated, please use options.freeSocketTimeout instead
server    log   [17:24:17.474] [info][plugins][queryEnhancements] queryEnhancements: Setup complete
[agentkeepalive:deprecated] options.freeSocketKeepAliveTimeout is deprecated, please use options.freeSocketTimeout instead
[agentkeepalive:deprecated] options.freeSocketKeepAliveTimeout is deprecated, please use options.freeSocketTimeout instead
[agentkeepalive:deprecated] options.freeSocketKeepAliveTimeout is deprecated, please use options.freeSocketTimeout instead
server    log   [17:24:34.938] [info][dynamic-config-service] initiating start()
server    log   [17:24:34.950] [info][dynamic-config-service] finished start()
server    log   [17:24:35.164] [info][savedobjects-service] Waiting until all OpenSearch nodes are compatible with OpenSearch Dashboards before starting saved objects migrations...
server    log   [17:24:35.626] [info][savedobjects-service] Starting saved objects migrations
server    log   [17:24:35.978] [info][savedobjects-service] Creating index .kibana_1.
server    log   [17:24:40.349] [info][savedobjects-service] Pointing alias .kibana to .kibana_1.
server    log   [17:24:40.706] [info][savedobjects-service] Finished in 4758ms.
server    log   [17:24:40.849] [warning][cross-compatibility-service] Starting cross compatibility service
server    log   [17:24:40.859] [info][plugins-system] Starting [41] plugins: [usageCollection,opensearchDashboardsUsageCollection,opensearchDashboardsLegacy,mapsLegacy,opensearchUiShared,share,legacyExport,embeddable,expressions,data,savedObjects,queryEnhancements,home,dashboard,visualizations,visTypeVega,visTypeTimeline,visTypeTable,visTypeMarkdown,visBuilder,visAugmenter,tileMap,regionMap,inputControlVis,visualize,apmOss,management,indexPatternManagement,dataSourceManagement,alertingDashboards,console,advancedSettings,dataExplorer,charts,visTypeVislib,visTypeTimeseries,visTypeTagcloud,visTypeMetric,discover,savedObjectsManagement,bfetch]
server    log   [17:24:43.645] [info][listening] Server running at http://localhost:5603/nho
server    log   [17:24:44.621] [info][server][OpenSearchDashboards][http] http server running at http://localhost:5603/nho
np bld    log   [17:27:32.090] [warning][@osd/optimizer] worker stderr [BABEL] Note: The code generator has deoptimised the styling of /local/home/nvinjam/Github/OpenSearch-Dashboards/packages/osd-antlr-grammar/target/opensearch_ppl_simplified/.generated/OpenSearchPPLParser.js as it exceeds the max of 500KB.
np bld    log   [17:28:01.542] [success][@osd/optimizer] 60 bundles compiled successfully after 260.8 sec, watching for changes

Changelog

  • fix: Update the version check logic

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@nvinjam-amazon nvinjam-amazon changed the title Nvinjam dev Updated the version check logic during start of OSD server. Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.54%. Comparing base (92ff168) to head (55ad9a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10818      +/-   ##
==========================================
- Coverage   60.54%   60.54%   -0.01%     
==========================================
  Files        4514     4514              
  Lines      121393   121393              
  Branches    20273    20273              
==========================================
- Hits        73502    73498       -4     
- Misses      42742    42744       +2     
- Partials     5149     5151       +2     
Flag Coverage Δ
Linux_1 26.57% <0.00%> (ø)
Linux_2 38.83% <100.00%> (ø)
Linux_3 ?
Linux_4 33.63% <0.00%> (-0.01%) ⬇️
Windows_1 26.58% <0.00%> (ø)
Windows_2 38.81% <100.00%> (ø)
Windows_3 39.09% <0.00%> (ø)
Windows_4 33.63% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruanyl
Copy link
Member

ruanyl commented Oct 29, 2025

@nvinjam-amazon I believe enforing exact version match is by intention, could you elaborate the motivation of changing to major version match? Also this doesn't seem is a fix, sounds more like a breaking change to me.

@nvinjam-amazon
Copy link
Contributor Author

nvinjam-amazon commented Oct 29, 2025

@ruanyl This is mainly the issue with release process. Recently we have introduced a CLI flag --single-version with different modes, which gives us different options to check for version in different cases. That has been added as a day by day build process. So, CLI part is fine. But, the check is also happening during the start of the OSD server, which needs to be aligned with CLI installation logic. The CLI flag --single-version has been implemeted in both OSS and AOS. For this one too, we want to align between AOS and OSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants